On Monday, May 17, 2021 1:10:58 PM EDT Tedd Ho-Jeong An wrote: > On Sat, 2021-05-15 at 09:43 -0400, Steve Grubb wrote: > > This patch fixes a couple memory leaks. > > > > In filesystem, g_file_get_contents allocates fresh memory to buf. > > It needs to be freed after conversion to a GString object. > > > > Destination was missed on an error path as is mld. > > > > --- > > obexd/plugins/filesystem.c | 2 +- > > obexd/plugins/ftp.c | 8 ++++++-- > > obexd/plugins/messages-dummy.c | 1 + > > 3 files changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/obexd/plugins/filesystem.c b/obexd/plugins/filesystem.c > > index 09bff8ad0..44e3cf3d2 100644 > > --- a/obexd/plugins/filesystem.c > > +++ b/obexd/plugins/filesystem.c@@ -416,6 +416,7 @@ static void > > *capability_open(const char *name, int oflag, mode_t mode, > > CI wasn't able to apply the patch and couldn't run the tests, and I think > because of this line. Hmm. Apologies. I'll regenerate the patch and send it again. Cheers, -Steve
