RE: [PATCH v6 2/2] Bluetooth: Add support for Read Local Supported Codecs V2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

> > +
> > static void hci_init5_req(struct hci_dev *hdev) {
> > 	/* Read local codec list if the HCI command is supported */
> > -	if (hdev->commands[29] & 0x20)
> > +	if (hdev->commands[45] & 0x04)
> > +		hci_read_supported_codecs_v2(hdev);
> > +	else if (hdev->commands[29] & 0x20)
> > 		hci_read_supported_codecs(hdev);
> > }
> 
> now I see what you are doing here. Don’t use the name hci_init5_req since
> that is misleading. Just put this right into init main function. No need to
> obstruct it.

I will fix  and send updated version. Thanks.
> 
> Regards
> 
> Marcel

Regards,
Kiran






[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux