Re: [Bluez PATCH v2] btmgmt: Fix enable adding irk when turining privacy on

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sathish,

On Tue, May 4, 2021 at 4:09 AM Sathish Narasimman
<sathish.narasimman@xxxxxxxxx> wrote:
>
> Unable to add the IRK in btmgmt when need to be updated. The option is
> enabled now.
>
> Signed-off-by: Sathish Narasimman <sathish.narasimman@xxxxxxxxx>
> ---
>  tools/btmgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/btmgmt.c b/tools/btmgmt.c
> index 02fec1dca184..bf3b460d0f04 100644
> --- a/tools/btmgmt.c
> +++ b/tools/btmgmt.c
> @@ -5277,7 +5277,7 @@ static const struct bt_shell_menu main_menu = {
>         cmd_advertising,                "Toggle LE advertising",        },
>         { "bredr",              "<on/off>",
>                 cmd_bredr,              "Toggle BR/EDR support",        },
> -       { "privacy",            "<on/off>",
> +       { "privacy",            "<on/off> [irk]",
>                 cmd_privacy,            "Toggle privacy support"        },

I wonder why you didn't incorporate in the first parameter though
given that things like privacy off [irk] makes no send, or perhaps
have a dedicated command for setting the irk so it would persist
between privacy on/off.

>         { "class",              "<major> <minor>",
>                 cmd_class,              "Set device major/minor class"  },
> --
> 2.17.1
>


-- 
Luiz Augusto von Dentz



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux