Re: [PATCH v5 1/2] Bluetooth: enumerate local supported codec and cache details

[kernel test robot <lkp@xxxxxxxxx>]

Hi Kiran,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on v5.12 next-20210430]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kiran-K/Bluetooth-enumerate-local-supported-codec-and-cache-details/20210502-172037
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: h8300-randconfig-r036-20210502 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2047ed70959f18851849f43d2d7eec9e5486e192
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kiran-K/Bluetooth-enumerate-local-supported-codec-and-cache-details/20210502-172037
        git checkout 2047ed70959f18851849f43d2d7eec9e5486e192
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:10,
                    from include/linux/rfkill.h:33,
                    from net/bluetooth/hci_core.c:29:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   include/asm-generic/page.h:89:50: warning: ordered comparison of pointer with null pointer [-Wextra]
      89 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
         |                                                  ^~
   include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
      78 | # define unlikely(x) __builtin_expect(!!(x), 0)
         |                                          ^
   include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |  ^~~~~~
   include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid'
     137 |  BUG_ON(!virt_addr_valid(buf));
         |          ^~~~~~~~~~~~~~~
   net/bluetooth/hci_core.c: At top level:
>> net/bluetooth/hci_core.c:987:6: warning: no previous prototype for 'hci_codec_list_parse' [-Wmissing-prototypes]
     987 | void hci_codec_list_parse(struct hci_dev *hdev, __u8 num_codecs,
         |      ^~~~~~~~~~~~~~~~~~~~


vim +/hci_codec_list_parse +987 net/bluetooth/hci_core.c

   986	
 > 987	void hci_codec_list_parse(struct hci_dev *hdev, __u8 num_codecs,
   988				  void *codec_list, bool is_vendor_codec)
   989	{
   990		__u8 i;
   991	
   992		for (i = 0; i < num_codecs; i++) {
   993			if (!is_vendor_codec) {
   994				struct hci_standard_codecs *codecs = codec_list;
   995	
   996				hci_read_codec_capabilities(hdev, &codecs->codec[i],
   997							    LOCAL_CODEC_ACL_MASK,
   998							    is_vendor_codec);
   999			} else {
  1000				struct hci_vendor_codecs *codecs = codec_list;
  1001	
  1002				hci_read_codec_capabilities(hdev, &codecs->codec[i],
  1003							    LOCAL_CODEC_ACL_MASK,
  1004							    is_vendor_codec);
  1005			}
  1006		}
  1007	}
  1008	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip