Re: [RFC PATCH v1] doc/mgmt-api - Return connection direction in Device Connected Event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yu,

> When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user
> space we will set the flags to tell if the established connection is
> outbound or not. This is useful for the user space to log better metrics
> and error messages.
> 
> Reviewed-by: Miao-chen Chou <mcchou@xxxxxxxxxxxx>
> Reviewed-by: Alain Michaud <alainm@xxxxxxxxxxxx>
> ---
> 
> Changes in v1:
> - Initial change
> 
> doc/mgmt-api.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index cab1fffc5..534272045 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -4085,7 +4085,7 @@ Device Connected Event
> 	start using its identity.
> 
> 	The following bits are defined for the Flags parameter:
> -		0	Reserved (not in use)
> +		0	Outbound Connection
> 		1	Legacy Pairing
> 		2	Reserved (not in use)

the reserved ones are there to keep in sync with Device Found. So please use the next free one (and reserve it for Device Found).

Also I am not fully in favor of “Outbound Connection”. I rather use the term “Central” in case we are the Central / Master of a connection. Now that however gets into trouble with BR/EDR since there you can switch roles. So maybe “Initiated Connection” is an option.

Regards

Marcel




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux