Re: [PATCH 2/3] Bluetooth: Add BTPROTO_ISO socket type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

I love your patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on v5.11-rc1 next-20201223]
[cannot apply to bluetooth/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Luiz-Augusto-von-Dentz/Bluetooth-Add-initial-implementation-of-CIS-connections/20201222-054425
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0c29289286983b97fb21b564e19fc1eed47ae0bd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Luiz-Augusto-von-Dentz/Bluetooth-Add-initial-implementation-of-CIS-connections/20201222-054425
        git checkout 0c29289286983b97fb21b564e19fc1eed47ae0bd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   In file included from net/bluetooth/iso.c:30:
>> include/net/bluetooth/bluetooth.h:161:30: warning: initialized field overwritten [-Woverride-init]
     161 | #define BT_ISO_QOS_CIS_UNSET 0xff
         |                              ^~~~
   net/bluetooth/iso.c:529:10: note: in expansion of macro 'BT_ISO_QOS_CIS_UNSET'
     529 |  .cig  = BT_ISO_QOS_CIS_UNSET,
         |          ^~~~~~~~~~~~~~~~~~~~
   include/net/bluetooth/bluetooth.h:161:30: note: (near initialization for 'default_qos.cig')
     161 | #define BT_ISO_QOS_CIS_UNSET 0xff
         |                              ^~~~
   net/bluetooth/iso.c:529:10: note: in expansion of macro 'BT_ISO_QOS_CIS_UNSET'
     529 |  .cig  = BT_ISO_QOS_CIS_UNSET,
         |          ^~~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for FRAME_POINTER
   Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
   Selected by
   - FAULT_INJECTION_STACKTRACE_FILTER && FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT && !X86_64 && !MIPS && !PPC && !S390 && !MICROBLAZE && !ARM && !ARC && !X86


vim +161 include/net/bluetooth/bluetooth.h

7c800e5d3fe2926 Luiz Augusto von Dentz 2020-12-21  159  
7c800e5d3fe2926 Luiz Augusto von Dentz 2020-12-21  160  #define BT_ISO_QOS_CIG_UNSET	0xff
7c800e5d3fe2926 Luiz Augusto von Dentz 2020-12-21 @161  #define BT_ISO_QOS_CIS_UNSET	0xff
7c800e5d3fe2926 Luiz Augusto von Dentz 2020-12-21  162  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux