RE: [Bluez,v1,1/4] shared/mgmt: Add supports of parsing mgmt tlv list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=406659

---Test result---

##############################
Test: CheckPatch - FAIL
Output:
btmgmt: Add command set-sysconfig
WARNING:NAKED_SSCANF: unchecked sscanf return value
#42: FILE: tools/btmgmt.c:1818:
+		if (!sscanf(input + i * 2, "%2hhx", &value[i]))
+			return false;

- total: 0 errors, 1 warnings, 121 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] btmgmt: Add command set-sysconfig" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: CheckGitLint - FAIL
Output:
btmgmt: Add command set-sysconfig
8: B3 Line contains hard tab characters (\t): "	-v <type:length:value>..."
10: B3 Line contains hard tab characters (\t): "	set-sysconfig -v 001a:2:1234 001f:1:00"


##############################
Test: CheckBuild - FAIL
Output:
src/shared/mgmt.c: In function ‘mgmt_tlv_list_free’:
src/shared/mgmt.c:598:37: error: passing argument 2 of ‘queue_destroy’ from incompatible pointer type [-Werror=incompatible-pointer-types]
  598 |  queue_destroy(tlv_list->tlv_queue, mgmt_tlv_free);
      |                                     ^~~~~~~~~~~~~
      |                                     |
      |                                     void (*)(struct mgmt_tlv *)
In file included from src/shared/mgmt.c:25:
./src/shared/queue.h:23:62: note: expected ‘queue_destroy_func_t’ {aka ‘void (*)(void *)’} but argument is of type ‘void (*)(struct mgmt_tlv *)’
   23 | void queue_destroy(struct queue *queue, queue_destroy_func_t destroy);
      |                                         ~~~~~~~~~~~~~~~~~~~~~^~~~~~~
src/shared/mgmt.c: In function ‘mgmt_tlv_list_load_from_buf’:
src/shared/mgmt.c:641:28: error: initialization of ‘struct mgmt_tlv *’ from incompatible pointer type ‘const uint8_t *’ {aka ‘const unsigned char *’} [-Werror=incompatible-pointer-types]
  641 |   struct mgmt_tlv *entry = cur;
      |                            ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:6808: src/shared/mgmt.lo] Error 1
make: *** [Makefile:4023: all] Error 2


##############################
Test: MakeCheck - SKIPPED
Output:
checkbuild not success



---
Regards,
Linux Bluetooth


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux