RE: [BlueZ,1/4] lib: Add definitions for ISO socket

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=405035

---Test result---

##############################
Test: CheckPatch - FAIL
Output:
lib: Add definitions for ISO socket
WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#55: FILE: lib/iso.h:1:
+/*

ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
#73: FILE: lib/iso.h:19:
+ *  along with this program; if not, write to the Free Software$

ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
#74: FILE: lib/iso.h:20:
+ *  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA$

- total: 2 errors, 1 warnings, 81 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] lib: Add definitions for ISO socket" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

tools: Add isotest tool
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#91: FILE: tools/isotest.c:55:
+static int defer_setup = 0;

ERROR:GLOBAL_INITIALISERS: do not initialise globals to NULL
#93: FILE: tools/isotest.c:57:
+struct bt_iso_qos *iso_qos = NULL;

ERROR:SPACING: space required after that ',' (ctx:VxV)
#271: FILE: tools/isotest.c:235:
+		syslog(LOG_ERR,"Can not listen on the socket: %s (%d)",
 		              ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#276: FILE: tools/isotest.c:240:
+	syslog(LOG_INFO,"Waiting for connection ...");
 	               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#284: FILE: tools/isotest.c:248:
+			syslog(LOG_ERR,"Accept failed: %s (%d)",
 			              ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#337: FILE: tools/isotest.c:301:
+	syslog(LOG_INFO,"Receiving ...");
 	               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#353: FILE: tools/isotest.c:317:
+	struct timeval tv_beg,tv_end,tv_diff;
 	                     ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#353: FILE: tools/isotest.c:317:
+	struct timeval tv_beg,tv_end,tv_diff;
 	                            ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#399: FILE: tools/isotest.c:363:
+		syslog(LOG_INFO,"%ld bytes in %.2f sec speed %.2f kb/s", total,
 		               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#409: FILE: tools/isotest.c:373:
+	syslog(LOG_INFO,"Opening %s ...", filename);
 	               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#455: FILE: tools/isotest.c:419:
+	syslog(LOG_INFO,"Sending ...");
 	               ^

ERROR:SPACING: space required before the open brace '{'
#519: FILE: tools/isotest.c:483:
+		for (i = 0; i < 10; i++){

ERROR:SPACING: space prohibited before that ',' (ctx:WxV)
#661: FILE: tools/isotest.c:625:
+int main(int argc ,char *argv[])
                   ^

ERROR:SPACING: space required after that ',' (ctx:WxV)
#661: FILE: tools/isotest.c:625:
+int main(int argc ,char *argv[])
                   ^

ERROR:SPACING: space required before the open parenthesis '('
#683: FILE: tools/isotest.c:647:
+		switch(opt) {

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#797: FILE: tools/isotest.c:761:
+		/* Fallthrough */

- total: 15 errors, 1 warnings, 862 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] tools: Add isotest tool" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

btio: Add support for ISO sockets
WARNING:LINE_SPACING: Missing a blank line after declarations
#52: FILE: btio/btio.c:781:
+		int error = -errno;
+		ERROR_FAILED(err, "sco_bind", errno);

- total: 0 errors, 1 warnings, 419 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] btio: Add support for ISO sockets" has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: CheckGitLint - FAIL
Output:
lib: Add definitions for ISO socket
3: B6 Body message is missing


##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS



---
Regards,
Linux Bluetooth


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux