Thanks for the quick turnaround Luiz. Converging onto BR instead of
BREDR also works.
On Tue, Dec 1, 2020 at 6:13 PM Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
>
> Hi Alain,
>
> On Tue, Dec 1, 2020 at 3:03 PM Alain Michaud <alainmichaud@xxxxxxxxxx> wrote:
> >
> > I likely won't get to it for a little while, but if someone will be
> > fixing this, we also noticed this issue while reviewing the related
> > patch:
> >
> > { "PageTimeout",
> > &btd_opts.defaults.br.page_timeout,
> > sizeof(btd_opts.defaults.br.page_scan_win), //<-- this should also be
> > page_timeout rather than page_scan_win
> > 0x0001,
> > 0xFFFF},
>
> Nice catch:
>
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=a37d53db9ae7d21a8f812925303d767d3f03e597
>
> > Thanks!
> > Alain
> >
> > On Tue, Dec 1, 2020 at 5:53 PM Ronan Pigott <rpigott314@xxxxxxxxx> wrote:
> > >
> > > On Tue Dec 1, 2020 at 8:33 AM MST, Alain Michaud wrote:
> > > > Hi Luiz/Ronan,
> > > >
> > > > This appears to have been an incorrect fix since
> > > > parse_mode_config(config, "BREDR", params, ARRAY_SIZE(params)); will
> > > > attempt to read from the BREDR section. My suggestion would be to
> > > > update the group table entry instead:
> > >
> > > Oh, that's right. Whoops.
> > >
> > > Updating the group table sounds good to me.
>
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=e2863c003c8e65b386a981ef6037518beb605795
>
> So now everything should be using BR as group name.
>
>
> --
> Luiz Augusto von Dentz
