This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=381601 ---Test result--- ############################## Test: CheckPatch - FAIL Output: battery: Add the internal Battery API ERROR:INITIALISED_STATIC: do not initialise statics to NULL #70: FILE: src/battery.c:37: +static struct queue *batteries = NULL; ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #72: FILE: src/battery.c:39: +static void battery_add(struct btd_battery *battery) { ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #79: FILE: src/battery.c:46: +static void battery_remove(struct btd_battery *battery) { - total: 3 errors, 0 warnings, 212 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] battery: Add the internal Battery API" has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. test: Add test app for Battery Provider API ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #12: FILE: test/example-battery-provider - total: 1 errors, 0 warnings, 230 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] test: Add test app for Battery Provider API" has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: CheckGitLint - PASS ############################## Test: CheckBuild - FAIL Output: ar: `u' modifier ignored since `D' is the default (see `U') ar: `u' modifier ignored since `D' is the default (see `U') ar: `u' modifier ignored since `D' is the default (see `U') ar: `u' modifier ignored since `D' is the default (see `U') ar: `u' modifier ignored since `D' is the default (see `U') src/battery.c:156:21: error: no previous declaration for ‘btd_battery_register’ [-Werror=missing-declarations] 156 | struct btd_battery *btd_battery_register(const char *path, const char *source, | ^~~~~~~~~~~~~~~~~~~~ src/battery.c:193:6: error: no previous declaration for ‘btd_battery_unregister’ [-Werror=missing-declarations] 193 | bool btd_battery_unregister(struct btd_battery *battery) | ^~~~~~~~~~~~~~~~~~~~~~ src/battery.c:217:6: error: no previous declaration for ‘btd_battery_update’ [-Werror=missing-declarations] 217 | bool btd_battery_update(struct btd_battery *battery, uint8_t percentage) | ^~~~~~~~~~~~~~~~~~ src/battery.c: In function ‘register_battery_provider’: src/battery.c:463:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] 463 | struct battery_provider *provider = | ^~~~~~ src/battery.c: At top level: src/battery.c:528:6: error: no previous declaration for ‘manager_free’ [-Werror=missing-declarations] 528 | void manager_free(struct btd_battery_provider_manager *manager) | ^~~~~~~~~~~~ src/battery.c:541:1: error: no previous declaration for ‘btd_battery_provider_manager_create’ [-Werror=missing-declarations] 541 | btd_battery_provider_manager_create(struct btd_adapter *adapter) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/battery.c:567:6: error: no previous declaration for ‘btd_battery_provider_manager_destroy’ [-Werror=missing-declarations] 567 | void btd_battery_provider_manager_destroy( | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:9280: src/bluetoothd-battery.o] Error 1 make: *** [Makefile:4023: all] Error 2 ############################## Test: MakeCheck - SKIPPED Output: checkbuild not success --- Regards, Linux Bluetooth