Re: [PATCH] net: bluetooth: Fix null pointer dereference in hci_event_packet()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 01, 2020 at 09:06:42AM +0200, Marcel Holtmann wrote:
> Hi Anmol,
> 
> > AMP_MGR is getting derefernced in hci_phy_link_complete_evt(), when called from hci_event_packet() and there is a possibility, that hcon->amp_mgr may not be found when accessing after initialization of hcon.
> > 
> > - net/bluetooth/hci_event.c:4945
> > The bug seems to get triggered in this line:
> > 
> > bredr_hcon = hcon->amp_mgr->l2cap_conn->hcon;
> > 
> > Fix it by adding a NULL check for the hcon->amp_mgr before checking the ev-status.
> > 
> > Fixes: d5e911928bd8 ("Bluetooth: AMP: Process Physical Link Complete evt")
> > Reported-and-tested-by: syzbot+0bef568258653cff272f@xxxxxxxxxxxxxxxxxxxxxxxxx 
> > Link: https://syzkaller.appspot.com/bug?extid=0bef568258653cff272f 
> > Signed-off-by: Anmol Karn <anmol.karan123@xxxxxxxxx>
> > ---
> > Change in v3:
> >  - changed return o; to return; (Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > )
> > 
> > net/bluetooth/hci_event.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> 
> patch has been applied to bluetooth-next tree.
> 
> Regards
> 
> Marcel
> 

Thank you :)

Best,
Anmol



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux