Re: [BlueZ PATCH v5 1/8] adapter: Remove indirect dependency of headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz,

Thanks for the extra fix to get this series through! We're waiting for
further comments on
https://patchwork.kernel.org/project/bluetooth/list/?series=348071.

Regards,
Miao

On Mon, Sep 14, 2020 at 12:48 PM Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
>
> Hi Miao,
>
> On Fri, Sep 11, 2020 at 11:53 PM Miao-chen Chou <mcchou@xxxxxxxxxxxx> wrote:
> >
> > Given that adapter.h refers symbols from lib/bluetooth.h and lib/sdp.h,
> > these two headers should be included directly in adapter.h.
> >
> > Reviewed-by: Manish Mandlik <mmandlik@xxxxxxxxxxxx>
> > ---
> >
> > (no changes since v1)
> >
> >  src/adapter.h | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/src/adapter.h b/src/adapter.h
> > index f8ac20261..c70a7b0da 100644
> > --- a/src/adapter.h
> > +++ b/src/adapter.h
> > @@ -26,6 +26,9 @@
> >  #include <dbus/dbus.h>
> >  #include <glib.h>
> >
> > +#include <lib/bluetooth.h>
> > +#include <lib/sdp.h>
> > +
> >  #define MAX_NAME_LENGTH                248
> >
> >  /* Invalid SSP passkey value used to indicate negative replies */
> > --
> > 2.26.2
>
> Applied, thanks. Note that I did introduce a path to fix the build
> problem with  g_dbus_proxy_get_path.
>
> --
> Luiz Augusto von Dentz



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux