Re: [Bluez PATCH v3 1/2] doc/media-api: Add Press/Hold/Release methods for MediaPlayer1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Archie,

On Wed, Sep 2, 2020 at 8:50 PM Archie Pusaka <apusaka@xxxxxxxxxx> wrote:
>
> From: Archie Pusaka <apusaka@xxxxxxxxxxxx>
>
> This allows us to send any passthrough command. The button can also
> be held for an extended amount of time.
>
> Reviewed-by: Michael Sun <michaelfsun@xxxxxxxxxxxx>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> * Add Hold and Release methods
>
>  doc/media-api.txt | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/doc/media-api.txt b/doc/media-api.txt
> index dabc69936..e98573157 100644
> --- a/doc/media-api.txt
> +++ b/doc/media-api.txt
> @@ -199,6 +199,35 @@ Methods            void Play()
>                         Possible Errors: org.bluez.Error.NotSupported
>                                          org.bluez.Error.Failed
>
> +               void Press(byte avc_key)
> +
> +                       Press a specific key to send as passthrough command.
> +                       The key will be released automatically. Use Hold()
> +                       instead if the intention is to hold down the key.
> +
> +                       Possible Errors: org.bluez.Error.InvalidArguments
> +                                        org.bluez.Error.NotSupported
> +                                        org.bluez.Error.Failed
> +
> +               void Hold(byte avc_key)
> +
> +                       Press and hold a specific key to send as passthrough
> +                       command. It is your responsibility to make sure that
> +                       Release() is called after calling this method. The held
> +                       key will also be released when any other method in this
> +                       interface is called.
> +
> +                       Possible Errors: org.bluez.Error.InvalidArguments
> +                                        org.bluez.Error.NotSupported
> +                                        org.bluez.Error.Failed
> +
> +               void Release()
> +
> +                       Release the previously held key invoked using Hold().
> +
> +                       Possible Errors: org.bluez.Error.NotSupported
> +                                        org.bluez.Error.Failed
> +
>  Properties     string Equalizer [readwrite]
>
>                         Possible values: "off" or "on"
> --
> 2.28.0.402.g5ffc5be6b7-goog

Applied, thanks.

-- 
Luiz Augusto von Dentz



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux