Hi Luiz,
On Tue, Sep 1, 2020 at 1:47 PM Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
>
> Hi Alain,
>
> On Tue, Sep 1, 2020 at 8:43 AM Alain Michaud <alainmichaud@xxxxxxxxxx> wrote:
> >
> > Hi Marcel/Luiz,
> >
> > I'd be particularly interested in seeing your opinion on whether this could be better described as some form of SCO socket property... even if this is indeed an adapter property.
>
> Yep, but wasn't that supposed to be what BT_PKT_STATUS is for? I mean
> one can just attempt to read it with getsockopt and in case of returns
> an error it means the controller does not support it, that said it
> doesn't look like we do check the adapter features when using
> BT_PKT_STATUS, should that be checking if HCI_WIDEBAND_SPEECH_ENABLED
> is set?
The problem here is that this will be after the connection is created
and a packet is exchanged. In this context, we'd like to know if the
controller supports it ahead of creating a sco connection so we can
choose to use the headset at all. For example, there are devices and
circumstances where using the device's built-in mic and A2DP will
yield a better experience for the user so the platform may choose that
as a default for the user rather than degrading down to narrow-band.
>
> Also it doesn't seem we have updated userspace to support
> BT_PKT_STATUS, we should probably have something to test it via
> isotest and perhaps create a iso-tester.c to validate all the options.
>
> > Thanks,
> > Alain
> >
> > On Mon, Aug 31, 2020 at 5:44 PM Yu Liu <yudiliu@xxxxxxxxxx> wrote:
> >>
> >> +Alain Michaud
> >>
> >> Hi Marcel,
> >>
> >> Can you please comment on the cl as well as Luiz's suggestion? Thanks.
> >>
> >> On Thu, Aug 20, 2020 at 10:20 AM Yu Liu <yudiliu@xxxxxxxxxx> wrote:
> >> >
> >> > Friendly ping for comments from Marcel. Thanks.
> >> >
> >> >
> >> > On Mon, Aug 17, 2020 at 4:17 PM Luiz Augusto von Dentz
> >> > <luiz.dentz@xxxxxxxxx> wrote:
> >> > >
> >> > > Hi Marcel,
> >> > >
> >> > > On Mon, Aug 17, 2020 at 4:07 PM Yu Liu <yudiliu@xxxxxxxxxx> wrote:
> >> > > >
> >> > > > From: Archie Pusaka <apusaka@xxxxxxxxxxxx>
> >> > > >
> >> > > > Initially this is introduced to query whether WBS is supported by the adapter,
> >> > > > the API is generic enough to be extended to support querying others in
> >> > > > the future.
> >> > > >
> >> > > > Reviewed-by: sonnysasaka@xxxxxxxxxxxx
> >> > > >
> >> > > > Signed-off-by: Yu Liu <yudiliu@xxxxxxxxxx>
> >> > > > ---
> >> > > >
> >> > > > Changes in v2:
> >> > > > - Return an array of strings instead of a dict
> >> > > >
> >> > > > Changes in v1:
> >> > > > - Initial change
> >> > > >
> >> > > > doc/adapter-api.txt | 12 ++++++++++++
> >> > > > 1 file changed, 12 insertions(+)
> >> > > >
> >> > > > diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> >> > > > index 1a7255750..8fbcadb54 100644
> >> > > > --- a/doc/adapter-api.txt
> >> > > > +++ b/doc/adapter-api.txt
> >> > > > @@ -204,6 +204,18 @@ Methods void StartDiscovery()
> >> > > > org.bluez.Error.NotReady
> >> > > > org.bluez.Error.Failed
> >> > > >
> >> > > > + array{string} GetCapabilities()
> >> > > > +
> >> > > > + This method returns a list of supported
> >> > > > + capabilities that is populated when the adapter
> >> > > > + initiated.
> >> > > > +
> >> > > > + Possible values:
> >> > > > + "wbs" - Wide band speech
> >> > >
> >> > > Btw, should we stick to use wbs terminology here, or we should
> >> > > actually use the HCI feature/command, because wbs has actually to be
> >> > > implemented by the HFP afaik this is only indicating that the
> >> > > controller is able to notify packets drops, etc, with use of erroneous
> >> > > command. Perhaps we should actually use the term PLC (Packet Loss
> >> > > Concealment) instead since that seems to be the real capability here,
> >> > > afaik WBS does not actually require PLC.
> >> > >
> >> > > > +
> >> > > > + Possible errors: org.bluez.Error.NotReady
> >> > > > + org.bluez.Error.Failed
> >> > > > +
> >> > > > Properties string Address [readonly]
> >> > > >
> >> > > > The Bluetooth device address.
> >> > > > --
> >> > > > 2.28.0.220.ged08abb693-goog
> >> > > >
> >> > >
> >> > >
> >> > > --
> >> > > Luiz Augusto von Dentz
>
>
>
> --
> Luiz Augusto von Dentz
