Hi Luiz, The reason we introduced this method is because we need to send some of AVRCP category 2 passthroughs in order to be able to qualify the AVRCP absolute volume control as an audio source, despite we don't actually plan to send any passthrough in the practice. Therefore, which passthrough we send is actually not important (to us), as long as we can do that to satisfy the requirement. However, I see that there are over 50 passthroughs across category 1 - 4, and thought that it would be cumbersome to have a different method for each key if one day we decided to support them all, hence the generic method. May I have some questions? (1) Why do you prefer a dedicated method per key? (2) Let's say I need to add a dedicated method for a single category 2 passthrough key, do you have a key in mind or I can just pick by myself? Thanks, Archie On Tue, 1 Sep 2020 at 01:16, Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote: > > Hi Archie, > > On Mon, Aug 31, 2020 at 12:37 AM Archie Pusaka <apusaka@xxxxxxxxxx> wrote: > > > > From: Archie Pusaka <apusaka@xxxxxxxxxxxx> > > > > This allows us to send any passthrough command. > > > > Reviewed-by: Michael Sun <michaelfsun@xxxxxxxxxx> > > --- > > > > doc/media-api.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/doc/media-api.txt b/doc/media-api.txt > > index dabc69936..fe7222eef 100644 > > --- a/doc/media-api.txt > > +++ b/doc/media-api.txt > > @@ -199,6 +199,14 @@ Methods void Play() > > Possible Errors: org.bluez.Error.NotSupported > > org.bluez.Error.Failed > > > > + void Press(byte avc_key) > > + > > + Press a specific key to send as passthrough command. > > + > > + Possible Errors: org.bluez.Error.InvalidArguments > > + org.bluez.Error.NotSupported > > + org.bluez.Error.Failed > > + > > Properties string Equalizer [readwrite] > > > > Possible values: "off" or "on" > > -- > > 2.28.0.402.g5ffc5be6b7-goog > > For now I would prefer to use dedicated method per key or are there > many keys you would like to use from the upper layer? > > > -- > Luiz Augusto von Dentz
