RE: [BlueZ,v2] shared/ad: move MAX_ADV_DATA_LEN macro to the header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkbuild Failed

Outputs:
ar: `u' modifier ignored since `D' is the default (see `U')
src/shared/ad.c: In function ‘name_length’:
src/shared/ad.c:258:12: error: ‘MAX_ADV_DATA_LEN’ undeclared (first use in this function)
  258 |  if (len > MAX_ADV_DATA_LEN - *pos)
      |            ^~~~~~~~~~~~~~~~
src/shared/ad.c:258:12: note: each undeclared identifier is reported only once for each function it appears in
src/shared/ad.c: In function ‘serialize_name’:
src/shared/ad.c:427:12: error: ‘MAX_ADV_DATA_LEN’ undeclared (first use in this function)
  427 |  if (len > MAX_ADV_DATA_LEN - (*pos + 2)) {
      |            ^~~~~~~~~~~~~~~~
src/shared/ad.c: In function ‘bt_ad_generate’:
src/shared/ad.c:479:16: error: ‘MAX_ADV_DATA_LEN’ undeclared (first use in this function)
  479 |  if (*length > MAX_ADV_DATA_LEN)
      |                ^~~~~~~~~~~~~~~~
src/shared/ad.c: In function ‘bt_ad_add_manufacturer_data’:
src/shared/ad.c:587:13: error: ‘MAX_ADV_DATA_LEN’ undeclared (first use in this function)
  587 |  if (len > (MAX_ADV_DATA_LEN - 2 - sizeof(uint16_t)))
      |             ^~~~~~~~~~~~~~~~
src/shared/ad.c: In function ‘bt_ad_add_service_data’:
src/shared/ad.c:724:13: error: ‘MAX_ADV_DATA_LEN’ undeclared (first use in this function)
  724 |  if (len > (MAX_ADV_DATA_LEN - 2 - (size_t)bt_uuid_len(uuid)))
      |             ^~~~~~~~~~~~~~~~
src/shared/ad.c: In function ‘bt_ad_add_data’:
src/shared/ad.c:943:13: error: ‘MAX_ADV_DATA_LEN’ undeclared (first use in this function)
  943 |  if (len > (MAX_ADV_DATA_LEN - 2))
      |             ^~~~~~~~~~~~~~~~
make[1]: *** [Makefile:6807: src/shared/ad.lo] Error 1
make: *** [Makefile:4010: all] Error 2



---
Regards,
Linux Bluetooth

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux