This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.
Test Result:
checkpatch Failed
Outputs:
WARNING:LONG_LINE: line over 80 characters
#66: FILE: src/adapter.c:5130:
+ "Set Device Flags complete for unknown device %s", addr);
WARNING:NEW_TYPEDEFS: do not add new typedefs
#175: FILE: src/device.c:180:
+typedef enum {
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#351: FILE: src/device.c:3286:
+ * Otherwise, we enable if profile supports it. */
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#368: FILE: src/device.c:6702:
+uint32_t btd_device_get_current_flags(struct btd_device *dev) {
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#400: FILE: src/device.c:6734:
+ if (flag_value != wake_allowed) {
[...]
+ } else {
[...]
- total: 1 errors, 4 warnings, 390 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Your patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
