Hi Luiz,
On Mon, 2020-06-22 at 09:57 -0700, Luiz Augusto von Dentz wrote:
> Hi Tedd,
>
> On Fri, Jun 19, 2020 at 9:57 PM <bluez.test.bot@xxxxxxxxx> wrote:
> >
> > This is automated email and please do not reply to this email!
> >
> > Dear submitter,
> >
> > Thank you for submitting the patches to the linux bluetooth mailing list.
> > While we are preparing for reviewing the patches, we found the following
> > issue/warning.
> >
> > Test Result:
> > checkpatch Failed
> >
> > Outputs:
> > WARNING:SSCANF_TO_KSTRTO: Prefer kstrto<type> to single variable sscanf
> > #78: FILE: tools/btmgmt.c:4686:
> > + if (sscanf(argv[1], "%hx", &monitor_handle) != 1) {
> > + error("Wrong formatted handle argument");
> > + return bt_shell_noninteractive_quit(EXIT_FAILURE);
> > + }
>
> We might want to turn off this warning since it doesn't apply to
> userspace where kstrto is not available.
I made a change.
Also, I submit the patch to add .checkpatch.conf in the tree which will also
help others to run checkpatch before submissing.
Once it is checked in, I will update the CI.
>
> > - total: 0 errors, 1 warnings, 80 lines checked
> >
> > NOTE: For some of the reported defects, checkpatch may be able to
> > mechanically convert to the typical style using --fix or --fix-
> > inplace.
> >
> > Your patch has style problems, please review.
> >
> > NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT
> > FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING
> >
> > NOTE: If any of the errors are false positives, please report
> > them to the maintainer, see CHECKPATCH in MAINTAINERS.
> >
> >
> >
> > ---
> > Regards,
> > Linux Bluetooth
>
>
Regards,
Tedd Ho-Jeong An
