Re: [PATCH 14/14] Bluetooth: mgmt: Use command complete on success for set system config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,


On Wed, Jun 17, 2020 at 6:43 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> The command status reply is only for failure. When completing set system
> config command, the reply has to be command complete.
>
Reviewed-by: Alain Michaud <alainm@xxxxxxxxxxxx>
> Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> ---
>  net/bluetooth/mgmt_config.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/net/bluetooth/mgmt_config.c b/net/bluetooth/mgmt_config.c
> index 8e7ad2a51dbb..8d01a8ff85e9 100644
> --- a/net/bluetooth/mgmt_config.c
> +++ b/net/bluetooth/mgmt_config.c
> @@ -247,9 +247,8 @@ int set_def_system_config(struct sock *sk, struct hci_dev *hdev, void *data,
>                 buffer += exp_len;
>         }
>
> -       return mgmt_cmd_status(sk, hdev->id,
> -                              MGMT_OP_SET_DEF_SYSTEM_CONFIG,
> -                              MGMT_STATUS_SUCCESS);
> +       return mgmt_cmd_complete(sk, hdev->id,
> +                                MGMT_OP_SET_DEF_SYSTEM_CONFIG, 0, NULL, 0);
>  }
>
>  int read_def_runtime_config(struct sock *sk, struct hci_dev *hdev, void *data,
> --
> 2.26.2
>

Thanks,
Alain



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux