Re: [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 15, 2020 at 11:18 PM Von Dentz, Luiz
<luiz.von.dentz@xxxxxxxxx> wrote:
>
> Hi Miao,
>
> On Mon, Jun 15, 2020 at 9:28 PM Miao-chen Chou <mcchou@xxxxxxxxxxxx> wrote:
> >
> >  lib/mgmt.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/mgmt.h b/lib/mgmt.h
> > index f44f2465d..bb31156ab 100644
> > --- a/lib/mgmt.h
> > +++ b/lib/mgmt.h
> > @@ -673,7 +673,7 @@ struct mgmt_adv_pattern {
> >         uint8_t value[31];
> >  } __packed;
> >
> > -#define MGMT_OP_ADD_ADV_MONITOR                        0x0052
> > +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR       0x0052
> >  struct mgmt_cp_add_adv_monitor {
> >         uint8_t pattern_count;
> >         struct mgmt_adv_pattern patterns[0];
> > --
> > 2.26.2
>
>
> The name already contains PATTERNS:
>
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/mgmt-api.txt#n3499

Nevermind this is actually the command name rather than its definition
which is what you are fixing.

-- 
Luiz Augusto von Dentz



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux