Re: [PATCH 2/4] Bluetooth: btintel: Add helper functions to dump boot/firmware info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kiran,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on bluetooth/master v5.7 next-20200611]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Kiran-K/Add-support-for-new-generation-Intel-controllers/20200611-194619
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: nds32-randconfig-r014-20200612 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from ./arch/nds32/include/generated/asm/bug.h:1,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/nds32/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:13,
from drivers/bluetooth/btintel.c:9:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/nds32/include/asm/memory.h:82:32: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
82 | #define pfn_valid(pfn)  ((pfn) >= PHYS_PFN_OFFSET && (pfn) < (PHYS_PFN_OFFSET + max_mapnr))
|                                ^~
include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE'
139 |  int __ret_warn_once = !!(condition);            |                           ^~~~~~~~~
include/linux/dma-mapping.h:352:19: note: in expansion of macro 'pfn_valid'
352 |  if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
|                   ^~~~~~~~~
drivers/bluetooth/btintel.c: At top level:
>> drivers/bluetooth/btintel.c:229:6: warning: no previous prototype for 'btintel_boot_info' [-Wmissing-prototypes]
229 | void btintel_boot_info(struct hci_dev *hdev,
|      ^~~~~~~~~~~~~~~~~
>> drivers/bluetooth/btintel.c:252:6: warning: no previous prototype for 'btintel_boot_info_tlv' [-Wmissing-prototypes]
252 | void btintel_boot_info_tlv(struct hci_dev *hdev,
|      ^~~~~~~~~~~~~~~~~~~~~

vim +/btintel_boot_info +229 drivers/bluetooth/btintel.c

   228	
 > 229	void btintel_boot_info(struct hci_dev *hdev,
   230			       struct intel_version_tlv *ver)
   231	{
   232		const char *variant;
   233	
   234		switch (ver->img_type) {
   235		case 0x01:
   236			variant = "Bootloader";
   237			break;
   238		case 0x03:
   239			variant = "Firmware";
   240			break;
   241		default:
   242			bt_dev_err(hdev, "Unsupported image type %x", ver->img_type);
   243			return;
   244		}
   245	
   246		bt_dev_info(hdev, "%s timestamp %u.%u buildtype %u build %u",
   247			    variant, 2000 + (ver->timestamp >> 8),
   248			    ver->timestamp & 0xff, ver->build_type, ver->build_num);
   249	}
   250	EXPORT_SYMBOL_GPL(btintel_boot_info);
   251	
 > 252	void btintel_boot_info_tlv(struct hci_dev *hdev,
   253				   struct intel_version_tlv *ver)
   254	{
   255		bt_dev_info(hdev, "Device revision is %u",
   256			    ver->dev_rev_id);
   257	
   258		bt_dev_info(hdev, "Secure boot is %s",
   259			    ver->secure_boot ? "enabled" : "disabled");
   260	
   261		bt_dev_info(hdev, "OTP lock is %s",
   262			    ver->otp_lock ? "enabled" : "disabled");
   263	
   264		bt_dev_info(hdev, "API lock is %s",
   265			    ver->api_lock ? "enabled" : "disabled");
   266	
   267		bt_dev_info(hdev, "Debug lock is %s",
   268			    ver->debug_lock ? "enabled" : "disabled");
   269	
   270		bt_dev_info(hdev, "Minimum firmware build %u week %u %u",
   271			    ver->min_fw_build_nn, ver->min_fw_build_cw,
   272			    2000 + ver->min_fw_build_yy);
   273	}
   274	EXPORT_SYMBOL_GPL(btintel_boot_info_tlv);
   275	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux