Requested feedback for new advertising MGMT command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Linux-bluetooth,

We are working on a feature to allow advertising clients to customize
both advertising intervals and requested tx power for each registered
advertising set. It is clear that the existing "add advertising" MGMT
command is not sufficient for these new features, so we have narrowed
it down to two options for the new interface, and hope for your
feedback:

Option 1 replicates existing MGMT command, and in addition provides
new interval and tx_power members.

#define MGMT_OP_ADD_EXT_ADVERTISING 0x00??
struct mgmt_cp_add_ext_advertising {
    uint8_t  instance;
    uint32_t flags;
    uint16_t timeout;
    uint16_t min_interval;
    uint16_t max_interval;
    int8_t tx_power;
    uint8_t  adv_data_len;
    uint8_t  scan_rsp_len;
    uint8_t  data[];
} __packed;

Option 2 packs the data into a flexible TLV data member. This allows
unused/unnecessary parameters to be omitted, and also allows for
future addition of functionality without redefining the MGMT
interface, for instance when more of the extended advertising features
are enabled in userspace.

#define MGMT_OP_ADD_EXT_ADVERTISING 0x00??
struct mgmt_cp_add_ext_advertising {
    uint8_t  instance;
    uint32_t flags;
    uint8_t  tlv_data[];
} __packed;

Feedback/comments/concerns are highly welcome, thanks in advance!

Best regards,
Daniel Winkler



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux