Hi Marcel,
> -----Original Message-----
> From: linux-bluetooth-owner@xxxxxxxxxxxxxxx <linux-bluetooth-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Marcel Holtmann
> Sent: Wednesday, June 3, 2020 11:12 PM
> To: K, Kiran <kiran.k@xxxxxxxxx>
> Cc: Bluez mailing list <linux-bluetooth@xxxxxxxxxxxxxxx>; Srivatsa, Ravishankar
> <ravishankar.srivatsa@xxxxxxxxx>; Tumkur Narayan, Chethan
> <chethan.tumkur.narayan@xxxxxxxxx>; Ps@xxxxxxxxxxxxxxx; Ps, AyappadasX
> <ayappadasx.ps@xxxxxxxxx>
> Subject: Re: [PATCH v2 1/2] Bluetooth: Add support to Intel read supported
> feature
>
> Hi Kiran,
>
> > The command shall read the Intel controller supported feature. Based
> > on the supported features addtional debug configuration shall be
> > enabled.
> >
> > Signed-off-by: Chethan T N <chethan.tumkur.narayan@xxxxxxxxx>
> > Signed-off-by: Ps, AyappadasX <AyappadasX.Ps@xxxxxxxxx>
> > Signed-off-by: Kiran K <kiran.k@xxxxxxxxx>
> > ---
> > drivers/bluetooth/btintel.c | 34 ++++++++++++++++++++++++++++++++++
> > drivers/bluetooth/btintel.h | 14 ++++++++++++++
> > drivers/bluetooth/btusb.c | 8 +++++++-
> > 3 files changed, 55 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> > index 6a0e2c5a8beb..09e697b92426 100644
> > --- a/drivers/bluetooth/btintel.c
> > +++ b/drivers/bluetooth/btintel.c
> > @@ -754,6 +754,40 @@ void btintel_reset_to_bootloader(struct hci_dev
> > *hdev) } EXPORT_SYMBOL_GPL(btintel_reset_to_bootloader);
> >
> > +int btintel_read_supported_features(struct hci_dev *hdev,
> > + struct intel_supported_features *supported_features) {
> > + struct sk_buff *skb;
> > + u8 page_no = 1;
> > +
> > + /* Intel controller supports two pages, each page is of 128-bit
> > + * feature bit mask. And each bit defines specific feature support
> > + */
> > + skb = __hci_cmd_sync(hdev, 0xfca6, sizeof(page_no), &page_no,
> > + HCI_INIT_TIMEOUT);
>
> Please get the coding style right first. We have plenty of examples in the same
> file on how to do this.
I have addressed all the issues reported by 'checkpatch.pl --strict' and sent updated patches. Thanks.
>
> Regards
>
> Marcel
