Re: [PATCH v2 2/2] avrcp: Don't attempt to load settings if on volume changed is supported

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-05-28 20:25, Luiz Augusto von Dentz wrote:
From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>

If only volume changed is supported that means the player cannot really
indicate track/metadata changes so don't attempt to read them.
---
  profiles/audio/avrcp.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 75811bf98..d46ac0ab7 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -3814,6 +3814,10 @@ static gboolean avrcp_get_capabilities_resp(struct avctp *conn, uint8_t code,
  	if (!session->controller || !session->controller->player)
  		return FALSE;
+ /* Skip if player status/metadata if only volume changes is supported */
+	if (events == AVRCP_EVENT_VOLUME_CHANGED)
+		return FALSE;
+
  	if ((session->controller->features & AVRCP_FEATURE_PLAYER_SETTINGS) &&
  			!(events & (1 << AVRCP_EVENT_SETTINGS_CHANGED)))
  		avrcp_list_player_attributes(session);


The result is still the same with this patch - MTW2 reboots after GetPlayStatus.

Attachment: mtw2.btsnoop
Description: Binary data

Attachment: mtw2.pcapng
Description: application/pcapng


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux