Hi Marcel,
On Wed, May 6, 2020 at 7:24 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> Hi Sonny,
>
> > Some clients may want to handle battery profile through the generic GATT
> > interface rather than BlueZ's internal Battery interface.
> > ---
> > Makefile.plugins | 2 ++
> > configure.ac | 4 ++++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/Makefile.plugins b/Makefile.plugins
> > index 98eee9ec8..b9733d31c 100644
> > --- a/Makefile.plugins
> > +++ b/Makefile.plugins
> > @@ -101,8 +101,10 @@ builtin_cppflags += $(ALSA_CFLAGS)
> > builtin_ldadd += $(ALSA_LIBS)
> > endif
> >
> > +if BATTERY
> > builtin_modules += battery
> > builtin_sources += profiles/battery/battery.c
> > +endif
> >
> > if SIXAXIS
> > plugin_LTLIBRARIES += plugins/sixaxis.la
> > diff --git a/configure.ac b/configure.ac
> > index 1433ace4a..d4fa862b5 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -181,6 +181,10 @@ AC_ARG_ENABLE(hog, AC_HELP_STRING([--disable-hog],
> > [disable HoG profile]), [enable_hog=${enableval}])
> > AM_CONDITIONAL(HOG, test "${enable_hog}" != "no")
> >
> > +AC_ARG_ENABLE(battery, AC_HELP_STRING([--disable-battery],
> > + [disable battery profile]), [enable_battery=${enableval}])
> > +AM_CONDITIONAL(BATTERY, test "${enable_battery}" != "no")
> > +
> > AC_ARG_ENABLE(health, AC_HELP_STRING([--enable-health],
> > [enable health profiles]), [enable_health=${enableval}])
> > AM_CONDITIONAL(HEALTH, test "${enable_health}" = "yes")
>
> I have a little bit concern splitting this since battery service and HoG are kinda connected. Wouldn’t it be better we have a cleaner interface. Maybe we should actually integrate cleanly with /dev/upower or similar.
I agree, we are re-evaluating this.
>
> Regards
>
> Marcel
>
