Hi,
On 4/28/20 11:39 AM, Marcel Holtmann wrote:
Hi Hans,
When the patch-ram is missing the hci_bcm code does not request the
IRQ, in this case we should not try to free it from bcm_close()
This fixes the following WARN statements + backtraces:
[ 332.670662] WARNING: CPU: 3 PID: 4743 at kernel/irq/devres.c:143 devm_free_irq+0x45/0x50
[ 332.670882] Trying to free already-free IRQ 44
[ 332.670891] WARNING: CPU: 3 PID: 4743 at kernel/irq/manage.c:1718 free_irq+0x1f4/0x390
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
---
drivers/bluetooth/hci_bcm.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
the patch doesn’t apply cleanly against bluetooth-next tree. Can you send a revised one. Thanks.
So I looked into rebasing the patch and it did not apply because
another (almost identical) fix for the issue has already landed
in bluetooth-next:
d5d0c62437c0 ("Bluetooth: hci_bcm: fix freeing not-requested IRQ")
So my version of this fix (this patch) can be dropped.
It would be good if this straight forward fix can be send to Linus
for one of the upcoming 5.7-rc# releases.
Regards,
Hans
