Hi Alain, On Thu, Apr 16, 2020 at 5:34 PM Alain Michaud <alainmichaud@xxxxxxxxxx> wrote: > > HI Luiz, > > On Thu, Apr 16, 2020 at 8:29 PM Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote: >> >> Hi Alain, >> >> On Thu, Apr 16, 2020 at 1:32 PM Alain Michaud <alainmichaud@xxxxxxxxxx> wrote: >> > >> > Friendly ping on this series. >> > >> > >> > On Fri, Apr 3, 2020 at 11:33 AM Alain Michaud <alainm@xxxxxxxxxxxx> wrote: >> > > >> > > This change adds an adapter Api to report the controller's >> > > widebandspeech enabled state. >> >> I wonder if this shouldn't be queried over SCO socket, or simple fail >> with BT_VOICE when using BT_VOICE_TRANSPARENT which is how what is >> normally used when using mSBC. > > I think there is value in both. Can you expand on that? I think this might generate confusion if the property indicates support for it but HFP implementation don't support it, since the later is usually implemented as a external profile so we don't have the features it may support, or perhaps the intention here is to actually indicate when it is in use? >> >> >> > > --- >> > > >> > > doc/adapter-api.txt | 8 ++++++++ >> > > 1 file changed, 8 insertions(+) >> > > >> > > diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt >> > > index acae032d9..d8865e795 100644 >> > > --- a/doc/adapter-api.txt >> > > +++ b/doc/adapter-api.txt >> > > @@ -326,3 +326,11 @@ Properties string Address [readonly] >> > > >> > > Local Device ID information in modalias format >> > > used by the kernel and udev. >> > > + >> > > + boolean WidebandSpeechEnabled [readonly] >> > > + >> > > + Returns true if the adapter's wideband speech feature is >> > > + supported and enabled. >> >> There seems to be some extra empty lines here. > > ACK, will fix. >> >> >> > > + >> > > + >> > > + >> > > -- >> > > 2.26.0.292.g33ef6b2f38-goog >> > > >> >> >> >> -- >> Luiz Augusto von Dentz -- Luiz Augusto von Dentz
