On Monday 13 April 2020 17:09:42 Luiz Augusto von Dentz wrote: > Hi Pali, > > On Mon, Apr 13, 2020 at 9:25 AM Pali Rohár <pali@xxxxxxxxxx> wrote: > > > > This patch series fixes handling of zero value in feature list and > > provides Remote audio volume control support for HSP profile in both HS > > and AG roles. > > > > Luiz, you wrote that you do not have time to work on this, so I > > implemented it myself in this patch series. Could you please find time > > at least for reviewing and merging these patches? Thanks. > > > > Pali Rohár (3): > > src/profile: Distinguish between zero-set HFP AG features and unset > > HFP AG features > > src/profile: Export Remote Audio Volume Control SDP value for HSP HS > > role via first bit in features value > > src/profile: Add default SDP record for Headset role of HSP 1.2 > > profile with Erratum 3507 > > > > src/profile.c | 112 ++++++++++++++++++++++++++++++++++++++++++++++---- > > 1 file changed, 104 insertions(+), 8 deletions(-) > > > > -- > > 2.20.1 > > Ive make some changes to remove the need to a flag to detect when the > features should be added or not, it is now applied, thanks. Ok, thank you! In commit you did one mistake: https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=040bd56a948f4d1ecd6987cdf0ba51779dc0c02a + /* HSP AG role does not provide any features */ + return 0; It should return -ENODATA as AG role does not provide any features, so has_features needs to be set to false.
