Thanks, Marcel.
Thanks, Guenter for finding this out.
On Tue, Apr 7, 2020 at 9:35 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> Hi Sonny,
>
> > Some static checker run by 0day reports a variableScope warning.
> >
> > net/bluetooth/smp.c:870:6: warning:
> > The scope of the variable 'err' can be reduced. [variableScope]
> >
> > There is no need for two separate variables holding return values.
> > Stick with the existing variable. While at it, don't pre-initialize
> > 'ret' because it is set in each code path.
> >
> > tk_request() is supposed to return a negative error code on errors,
> > not a bluetooth return code. The calling code converts the return
> > value to SMP_UNSPECIFIED if needed.
> >
> > Fixes: 92516cd97fd4 ("Bluetooth: Always request for user confirmation for Just Works")
> > Cc: Sonny Sasaka <sonnysasaka@xxxxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Reviewed-by: Sonny Sasaka <sonnysasaka@xxxxxxxxxxxx>
> > ---
> > net/bluetooth/smp.c | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
>
> patch has been applied to bluetooth-next tree.
>
> Regards
>
> Marcel
>
