Hi Marcel On Fri, Apr 3, 2020 at 11:24 PM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > > Hi Sathish, > > > For msbc encoded audio stream over usb transport, btusb driver > > to be set to alternate settings 6 as per BT core spec 5.0. The > > type of air mode is used to differenting which alt setting to be > > used. > > The changes are made considering some discussion over the similar > > patch submitted earlier from Kuba Pawlak(link below) > > https://www.spinics.net/lists/linux-bluetooth/msg64577.html > > > > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > Signed-off-by: Sathish Narasimman <sathish.narasimman@xxxxxxxxx> > > Signed-off-by: Chethan T N <chethan.tumkur.narayan@xxxxxxxxx> > > Signed-off-by: Hsin-Yu Chao <hychao@xxxxxxxxxxxx> > > Signed-off-by: Amit K Bag <amit.k.bag@xxxxxxxxx> > > --- > > drivers/bluetooth/btusb.c | 155 +++++++++++++++++++++++++++++--------- > > 1 file changed, 118 insertions(+), 37 deletions(-) > > I decided to look at these to patches and fix up a few things. > > 1) Use conn->setting & SCO_AIRMODE_MASK to select the option and with that also ensure that we don’t send this for ulaw and alaw air modes if they ever get established (even if unlikely). > > 2) Fix a bunch of coding style violation > > Please test these two patches if they still work according and then I can apply them. > > Regards > > Marcel > Tested these 2 patches and they are working fine Thanks Sathish N