Re: [PATCH] Bluetooth: Use bt_dev_err for RPA generation failure message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,


On Mon, Mar 9, 2020 at 5:48 PM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> When the RPA generation fails, indicate the error with a device specifc
> error message.
>
> Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> ---
>  net/bluetooth/hci_request.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
> index 2a1b64dbf76e..53179ae856ae 100644
> --- a/net/bluetooth/hci_request.c
> +++ b/net/bluetooth/hci_request.c
> @@ -1499,7 +1499,7 @@ int hci_get_random_address(struct hci_dev *hdev, bool require_privacy,
>
>                 err = smp_generate_rpa(hdev, hdev->irk, &hdev->rpa);
>                 if (err < 0) {
> -                       BT_ERR("%s failed to generate new RPA", hdev->name);
> +                       bt_dev_err(hdev, "failed to generate new RPA");
>                         return err;
>                 }
>
> --
> 2.24.1
>

LGTM.



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux