Hi Emil, On Wed, Mar 4, 2020 at 10:47 AM Emil Lenngren <emil.lenngren@xxxxxxxxx> wrote: > > Hi, > > Den ons 4 mars 2020 kl 18:36 skrev Luiz Augusto von Dentz > <luiz.dentz@xxxxxxxxx>: > > > > Hi Emil, > > > > On Wed, Mar 4, 2020 at 7:56 AM Emil Lenngren <emil.lenngren@xxxxxxxxx> wrote: > > > > > > Hi, > > > > > > Den ons 4 mars 2020 kl 11:55 skrev Jamie Mccrae <Jamie.Mccrae@xxxxxxxxxxxxxxxx>: > > > > > > > > Hi, > > > > > It should be fine also if the remote end sends an Exchange MTU request > > > > > at the beginning of the connection since we can then immediately send > > > > > a response and assign the MTU property without waiting for the > > > > > Exchange MTU response (that corresponds to our request). > > > > > > > > > > Let me know if you think I've missed some edge case... > > > > > > > > In the core specification 5.2 volume 3 part A, there is a command, L2CAP_CREDIT_BASED_RECONFIGURE_REQ, which allows for the MTU to be changed after it has been established. This requires an enhanced ATT service however, but it means that the initial MTU is subject to change. > > > > > > I just read the L2CAP/ATT/GATT parts in the new spec. Is EATT > > > implemented yet for the dbus-api, and will it affect the API? Anyway, > > > for EATT it's a requirement that the MTU can only increase, never > > > decrease, which shouldn't cause issues for apps. But change my "ATT > > > MTU exchanged" property name proposal to "Initial ATT MTU exchanged" > > > then, if waiting for the ServicesResolved wouldn't be enough, and set > > > it true immediately if EATT is used and after an Exchange MTU > > > procedure for unenhanced ATT. Then update the ATT MTU property when > > > the MTU is increased. > > > > It completely transparent to D-Bus, so if we do expose the MTU it > > should probably be reporting the biggest MTU of all connected channel, > > Is there ever any reason for one application to have more than one ATT > bearer? I thought the idea of EATT was to allow one ATT bearer per > application. EATT is meant to allow multiple outstanding requests, it probably would not escale if we would add an API to have a bearer per application so we just use the extra bearers as a pool. > > while it is possible to reconfigre the MTU with > > L2CAP_CREDIT_BASED_RECONFIGURE_REQ I doubt we would be exposing this > > sort of operation to applications, we have to keep in mind multiple > > application can request a change for their own needs so like Exchange > > MTU bluetoothd will be taking care of setting the MTU, > > I think it's fine that bluetoothd chooses the MTU. I don't see any > reason that the application should choose MTU (assuming bluetoothd > sets a big value). > > > that said with > > EATT incoming and outgoing MTUs don't need to be symmetric like the > > unenhanced bearer. > > While that is true on the L2CAP layer, it's not true on the GATT layer: > > Vol 3 Part G section 5.3.1: > "The ATT_MTU for the Enhanced ATT bearer shall be set to the minimum of the > MTU field values of the two devices; these values come from the L2CAP_- > CREDIT_BASED_CONNECTION_REQ and L2CAP_CREDIT_BASED_- > CONNECTION_RSP signaling packets or the latest L2CAP_CREDIT_- > BASED_RECONFIGURE_REQ packets." > > So if the peripheral sets its receive MTU to 48 and the central sets > its receive MTU to 517, then 48 will be used in both directions. This is kind of an artificial limitation that the author decided to impose on the bearer, but if it was adopted like that so be it. -- Luiz Augusto von Dentz
