Re: [PATCH v1] bluetooth: guard against controllers sending zero'd events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

On 1. Mar 2020, at 4.44, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>>> Why are you bothering to check for event here. Do we have requests set with hci_req.event == 0?
>> 
>> If I remember right, most requests are like that. req.event is only used then the request completes in something else than a command complete/status.
> 
> so what do we do then if we get an event == 0 from the controller? Just bail out early? It seems kind pointless to keep processing it.

Yeah, that’s what I’d do. Bail out early, but log a warning.

Johan



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux