Re: [PATCH] Bluetooth: btrtl: Use kvmalloc for FW allocations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Maxim,

> Currently, kmemdup is applied to the firmware data, and it invokes
> kmalloc under the hood. The firmware size and patch_length are big (more
> than PAGE_SIZE), and on some low-end systems (like ASUS E202SA) kmalloc
> may fail to allocate a contiguous chunk under high memory usage and
> fragmentation:
> 
> Bluetooth: hci0: RTL: examining hci_ver=06 hci_rev=000a lmp_ver=06 lmp_subver=8821
> Bluetooth: hci0: RTL: rom_version status=0 version=1
> Bluetooth: hci0: RTL: loading rtl_bt/rtl8821a_fw.bin
> kworker/u9:2: page allocation failure: order:4, mode:0x40cc0(GFP_KERNEL|__GFP_COMP), nodemask=(null),cpuset=/,mems_allowed=0
> <stack trace follows>
> 
> As firmware load happens on each resume, Bluetooth will stop working
> after several iterations, when the kernel fails to allocate an order-4
> page.
> 
> This patch replaces kmemdup with kvmalloc+memcpy. It's not required to
> have a contiguous chunk here, because it's not mapped to the device
> directly.
> 
> Signed-off-by: Maxim Mikityanskiy <maxtram95@xxxxxxxxx>
> ---
> drivers/bluetooth/btrtl.c | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux