Hi Alex, > These 2 macros are never used from first git commit Linux-2.6.12-rc2. So > better to remove them. > > Signed-off-by: Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx> > Cc: Marcel Holtmann <marcel@xxxxxxxxxxxx> > Cc: Johan Hedberg <johan.hedberg@xxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx> > Cc: linux-bluetooth@xxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > --- > net/bluetooth/rfcomm/core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/bluetooth/rfcomm/core.c b/net/bluetooth/rfcomm/core.c > index 3a9e9d9670be..825adff79f13 100644 > --- a/net/bluetooth/rfcomm/core.c > +++ b/net/bluetooth/rfcomm/core.c > @@ -73,8 +73,6 @@ static struct rfcomm_session *rfcomm_session_create(bdaddr_t *src, > > /* ---- RFCOMM frame parsing macros ---- */ > #define __get_dlci(b) ((b & 0xfc) >> 2) > -#define __get_channel(b) ((b & 0xf8) >> 3) > -#define __get_dir(b) ((b & 0x04) >> 2) > #define __get_type(b) ((b & 0xef)) > > #define __test_ea(b) ((b & 0x01)) it seems we are also not using __dir macro either. Regards Marcel
