On Thu, Jan 09, 2020 at 02:29:17PM +0100, Johan Hovold wrote: > On Thu, Jan 09, 2020 at 02:13:23PM +0100, guillaume La Roque wrote: > > > > On 1/9/20 11:53 AM, Johan Hovold wrote: > > > On Thu, Jan 09, 2020 at 11:42:56AM +0100, Guillaume La Roque wrote: > > >> add interrupts and interrupt-names as optional properties > > >> to support host-wakeup by interrupt properties instead of > > >> host-wakeup-gpios. > > >> > > >> Signed-off-by: Guillaume La Roque <glaroque@xxxxxxxxxxxx> > > >> --- > > >> Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 4 +++- > > >> 1 file changed, 3 insertions(+), 1 deletion(-) > > >> > > >> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > > >> index c44a30dbe43d..d33bbc998687 100644 > > >> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > > >> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > > >> @@ -37,7 +37,9 @@ Optional properties: > > >> - pcm-frame-type: short, long > > >> - pcm-sync-mode: slave, master > > >> - pcm-clock-mode: slave, master > > >> - > > >> + - interrupts: must be one, used to wakeup the host processor if > > >> + gpiod_to_irq function not supported > > >> + - interrupt-names: must be "host-wakeup" > > > Looks like you forgot to address Rob's comment. If I understood him > > > correctly you either need to stick with "host-wakeup-gpios" (and fix > > > your platform) or deprecate it in favour of "interrupts": > > > > > > https://lkml.kernel.org/r/20191218203818.GA8009@bogus > > > > not forgot marcel ask me a v6 > > Not much point in sending v6 before addressing feedback on v5. > Especially as Marcel asked for a v6 with acks. ;) > > > for rob comment ok but it's not possible to support gpiod_to_irq on my > > platform. > > > > if i deprecated it i need to update all DT with good interrupt number > > right? > > Not sure. Perhaps just updating the binding is enough. Rob? Correct. Just need to reflect in the binding which way is preferred. If it's a case of update all the dts files, then we often just don't document the old way. Rob
