Hi Marcel,
On Wed, Jan 8, 2020 at 1:23 PM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> Hi Luiz,
>
> > This enabled H4 driver to properly handle ISO packets.
> >
> > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
> > ---
> > drivers/bluetooth/hci_h4.c | 1 +
> > drivers/bluetooth/hci_uart.h | 7 +++++++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/drivers/bluetooth/hci_h4.c b/drivers/bluetooth/hci_h4.c
> > index 19ba52005009..6dc1fbeb564b 100644
> > --- a/drivers/bluetooth/hci_h4.c
> > +++ b/drivers/bluetooth/hci_h4.c
> > @@ -103,6 +103,7 @@ static const struct h4_recv_pkt h4_recv_pkts[] = {
> > { H4_RECV_ACL, .recv = hci_recv_frame },
> > { H4_RECV_SCO, .recv = hci_recv_frame },
> > { H4_RECV_EVENT, .recv = hci_recv_frame },
> > + { H4_RECV_ISO, .recv = hci_recv_frame },
> > };
> >
> > /* Recv data */
> > diff --git a/drivers/bluetooth/hci_uart.h b/drivers/bluetooth/hci_uart.h
> > index 6ab631101019..4e039d7a16f8 100644
> > --- a/drivers/bluetooth/hci_uart.h
> > +++ b/drivers/bluetooth/hci_uart.h
> > @@ -143,6 +143,13 @@ struct h4_recv_pkt {
> > .lsize = 1, \
> > .maxlen = HCI_MAX_EVENT_SIZE
> >
> > +#define H4_RECV_ISO \
> > + .type = HCI_ISODATA_PKT, \
> > + .hlen = HCI_ISO_HDR_SIZE, \
> > + .loff = 2, \
> > + .lsize = 2, \
> > + .maxlen = HCI_MAX_FRAME_SIZE \
> > +
> > struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb,
> > const unsigned char *buffer, int count,
> > const struct h4_recv_pkt *pkts, int pkts_count);
>
> there are a bunch of drivers that should be able to handle packet type 5. We should fix them all.
Indeed, I haven't looked into drivers I didn't have any means to test
but in theory that should be straight forward to support the new type
so I will try to add support to them as well.
> Regards
>
> Marcel
>
--
Luiz Augusto von Dentz
