Hi Guillem,
On Sat, 2019-12-14 at 10:40 +0100, Guillem Jover wrote:
> We are the client, so we should be using connect(2) instead of
> bind(2),
> otherwise when using non-abstract Unix sockets we will get an error
> that
> the address is already in use.
>
> This breaks the notify support in dpkg's start-stop-daemon.
> ---
> src/shared/mainloop-notify.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/shared/mainloop-notify.c b/src/shared/mainloop-
> notify.c
> index 89a880006..1de714a0e 100644
> --- a/src/shared/mainloop-notify.c
> +++ b/src/shared/mainloop-notify.c
> @@ -91,7 +91,7 @@ void mainloop_notify_init(void)
> if (addr.sun_path[0] == '@')
> addr.sun_path[0] = '\0';
>
> - if (bind(notify_fd, (struct sockaddr *) &addr, sizeof(addr)) <
> 0) {
> + if (connect(notify_fd, (struct sockaddr *) &addr, sizeof(addr))
> < 0) {
> close(notify_fd);
> notify_fd = -1;
> return;
Applied, thanks.
