Changes made to add a new method to parse the map conversation filters. Filters LastActivityBegin and LastActivityEnd is used to filter the conversations that are returned in the Conversation-Listing object by LastActivity. Co-authored-by: Bharat Bhusan Panda <bharat.b.panda@xxxxxxxxx> Signed-off-by: Ajay Kishore <ajay.kishore@xxxxxxxxx> --- obexd/client/map.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++-- obexd/src/map_ap.h | 3 +++ 2 files changed, 67 insertions(+), 2 deletions(-) diff --git a/obexd/client/map.c b/obexd/client/map.c index 57ca77e..9464606 100644 --- a/obexd/client/map.c +++ b/obexd/client/map.c @@ -1370,6 +1370,21 @@ static GObexApparam *parse_filter_type(GObexApparam *apparam, types); } +static GObexApparam *parse_la_begin(GObexApparam *apparam, + DBusMessageIter *iter) +{ + const char *string; + + if (dbus_message_iter_get_arg_type(iter) != DBUS_TYPE_STRING) + return NULL; + + dbus_message_iter_get_basic(iter, &string); + + return g_obex_apparam_set_string(apparam, + MAP_AP_FILTERLASTACTIVITYBEGIN, + string); +} + static GObexApparam *parse_period_begin(GObexApparam *apparam, DBusMessageIter *iter) { @@ -1398,6 +1413,20 @@ static GObexApparam *parse_period_end(GObexApparam *apparam, string); } +static GObexApparam *parse_la_end(GObexApparam *apparam, + DBusMessageIter *iter) +{ + const char *string; + + if (dbus_message_iter_get_arg_type(iter) != DBUS_TYPE_STRING) + return NULL; + + dbus_message_iter_get_basic(iter, &string); + + return g_obex_apparam_set_string(apparam, MAP_AP_FILTERLASTACTIVITYEND, + string); +} + static GObexApparam *parse_filter_read(GObexApparam *apparam, DBusMessageIter *iter) { @@ -1561,6 +1590,19 @@ static DBusMessage *map_list_messages(DBusConnection *connection, return get_message_listing(map, message, folder, apparam); } +static GObexApparam *parse_filter_conv_id(GObexApparam *apparam, + DBusMessageIter *iter) +{ + guint8 id; + + if (dbus_message_iter_get_arg_type(iter) != DBUS_TYPE_BYTE) + return NULL; + + dbus_message_iter_get_basic(iter, &id); + + return g_obex_apparam_set_uint8(apparam, MAP_AP_CONVERSATIONID, id); +} + static GObexApparam *parse_conversation_filters(GObexApparam *apparam, DBusMessageIter *iter) { @@ -1583,8 +1625,28 @@ static GObexApparam *parse_conversation_filters(GObexApparam *apparam, dbus_message_iter_next(&entry); dbus_message_iter_recurse(&entry, &value); - /* TODO: Parse conversation filters */ - + if (strcasecmp(key, "Offset") == 0) { + if (parse_offset(apparam, &value) == NULL) + return NULL; + } else if (strcasecmp(key, "MaxCount") == 0) { + if (parse_max_count(apparam, &value) == NULL) + return NULL; + } else if (strcasecmp(key, "LastActivityBegin") == 0) { + if (parse_la_begin(apparam, &value) == NULL) + return NULL; + } else if (strcasecmp(key, "FilterLastActivityEnd") == 0) { + if (parse_la_end(apparam, &value) == NULL) + return NULL; + } else if (strcasecmp(key, "Read") == 0) { + if (parse_filter_read(apparam, &value) == NULL) + return NULL; + } else if (strcasecmp(key, "Recipient") == 0) { + if (parse_filter_recipient(apparam, &value) == NULL) + return NULL; + } else if (strcasecmp(key, "ConversationId") == 0) { + if (parse_filter_conv_id(apparam, &value) == NULL) + return NULL; + } dbus_message_iter_next(&array); } return apparam; diff --git a/obexd/src/map_ap.h b/obexd/src/map_ap.h index da108fe..3773859 100644 --- a/obexd/src/map_ap.h +++ b/obexd/src/map_ap.h @@ -31,6 +31,8 @@ enum map_ap_tag { MAP_AP_FILTERREADSTATUS = 0x06, /* uint8_t */ MAP_AP_FILTERRECIPIENT = 0x07, /* char * */ MAP_AP_FILTERORIGINATOR = 0x08, /* char * */ + MAP_AP_FILTERLASTACTIVITYBEGIN = 0x08, /* char * */ + MAP_AP_FILTERLASTACTIVITYEND = 0x09, /* char * */ MAP_AP_FILTERPRIORITY = 0x09, /* uint8_t */ MAP_AP_ATTACHMENT = 0x0A, /* uint8_t */ MAP_AP_TRANSPARENT = 0x0B, /* uint8_t */ @@ -48,4 +50,5 @@ enum map_ap_tag { MAP_AP_STATUSINDICATOR = 0x17, /* uint8_t */ MAP_AP_STATUSVALUE = 0x18, /* uint8_t */ MAP_AP_MSETIME = 0x19, /* char * */ + MAP_AP_CONVERSATIONID = 0x1C, /* uint32_t */ }; -- 2.7.4