These were all whitespace issues and were autofixed with --inline. checkpatch is pretty noisy, so it's difficult to discern real issues with all this noise. Isn't it better to just fix the noise even if not consequential for a human reader and so we can focus on the real issues after? On Sun, Dec 8, 2019 at 3:31 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > > Hi Alain, > > > --- > > include/net/bluetooth/hci_core.h | 31 +++++++------ > > include/net/bluetooth/mgmt.h | 6 +-- > > net/bluetooth/hci_core.c | 45 +++++++++--------- > > net/bluetooth/mgmt.c | 49 ++++++++++++-------- > > net/bluetooth/smp.c | 78 ++++++++++++++++---------------- > > 5 files changed, 114 insertions(+), 95 deletions(-) > > can you please break these down into some logical chunks and include the checkpatch complaint in the commit message. None of these look like fundamental style violation. I am happy to take these kind of patches, but sometimes we do ignore checkpatch since the code itself is perfectly fine a human to read. > > Regards > > Marcel >
