Re: Proposal for key blacklisting via mgmt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alain,

> Here is a counter proposal which also aligns with the command op-code miss alignment patch sent earlier.
> 
> From 26d156f757c24d9e1313f2d14d528e219433b2bf Mon Sep 17 00:00:00 2001
> From: Alain Michaud <alainm@xxxxxxxxxxxx>
> Date: Tue, 26 Nov 2019 18:19:36 +0000
> Subject: [PATCH] Blocked key mgmt Api definition
> 
> ---
>  doc/mgmt-api.txt | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index 0d11aa035..7c77927a2 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -3013,6 +3013,39 @@ Set PHY Configuration Command
>  	Possible errors:	Invalid Parameters
>  	Invalid Index
> 
> +Load Blocked Keys Command
> +===========================
> +
> +	Command Code:	0x0046
> +	Controller Index:	<controller id>
> +	Command Parameters:	Key_Count (2 Octets)
> +	Key1 {
> +	Key_Type (1 Octet)
> +	Value (16 Octets)
> +	}
> +	Key2 { }
> +	...
> +	Return Parameters:
> +
> +	This command is used to feed the kernel a list of keys that
> +	are known to be vulnerable.
> +
> +	Currently defined Key_Type values are:
> +
> +	0x00	Link Key (BR/EDR)
> +	0x01	Long Term Key (LE)
> +	0x02	Identity Resolving Key (LE)
> +
> +	This command can be used at anypoint to add to the list of blocked keys.  Any connections that
> +	are attempting to use the keys will be terminated. If a device tries to distribute the keys during
> +	pairing, pairing will fail.
> +
> +	This command generates a Command Complete event on success or
> +	a Command Status event on failure.
> +
> +	Possible errors:	Invalid Parameters
> +	Invalid Index
> +

I would propose you utilize git-format-patch and git-send-email to ensure that we receive patches in ASCII format that I can apply utilizing git-am.

Regards

Marcel




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux