Hey, It looks about the same as one of my earlier patch series. Outside a few nitpicks, I'm ok with merging this. Thanks Abhishek On Sat, Nov 23, 2019 at 2:04 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > > Hi Abhishek, > > > While adding support for the BCM4354, I discovered a few more things > > that weren't working as they should have. > > > > First, we disallow serdev from setting the baudrate on BCM4354. Serdev > > sets the oper_speed first before calling hu->setup() in > > hci_uart_setup(). On the BCM4354, this results in bcm_setup() failing > > when the hci reset times out. > > > > Next, we add support for setting the PCM parameters, which consists of > > a pair of vendor specific opcodes to set the pcm parameters. The > > documentation for these params are available in the brcm_patchram_plus > > package (i.e. https://github.com/balena-os/brcm_patchram_plus). This is > > necessary for PCM to work properly. > > > > All changes were tested with rk3288-veyron-minnie.dts. > > so I have re-factored your patch set now to apply to latest bluetooth-next tree and posted it to the mailing list. Please have a look at it if this works for you. If it does, then we might just apply it this way and focus on getting detailed PCM codec configuration for all vendors in once we have a second vendor to unify it. > > Regards > > Marcel >
