Re: [PATCH 1/4] Bluetooth: hci_bcm: Disallow set_baudrate for BCM4354

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marcel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20191122]
[cannot apply to bluetooth-next/master bluetooth/master net-next/master v5.4-rc8 v5.4-rc7 v5.4-rc6 v5.4-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Marcel-Holtmann/Bluetooth-hci_bcm-Disallow-set_baudrate-for-BCM4354/20191125-034727
base:    b9d3d01405061bb42358fe53f824e894a1922ced
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/bluetooth/hci_bcm.c:1450:47: error: 'bcm4354_device_data' undeclared here (not in a function); did you mean 'bcm_device_data'?
     { .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data },
                                                  ^~~~~~~~~~~~~~~~~~~
                                                  bcm_device_data

vim +1450 drivers/bluetooth/hci_bcm.c

  1443	
  1444	#ifdef CONFIG_OF
  1445	static const struct of_device_id bcm_bluetooth_of_match[] = {
  1446		{ .compatible = "brcm,bcm20702a1" },
  1447		{ .compatible = "brcm,bcm4345c5" },
  1448		{ .compatible = "brcm,bcm4330-bt" },
  1449		{ .compatible = "brcm,bcm43438-bt" },
> 1450		{ .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data },
  1451		{ .compatible = "brcm,bcm4335a0" },
  1452		{ },
  1453	};
  1454	MODULE_DEVICE_TABLE(of, bcm_bluetooth_of_match);
  1455	#endif
  1456	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux