Hi Johan, >> The if-clause for hdev->setup should also include the error handling >> since that is where the error really comes from. The code currently >> works correctly since ret=0 is assigned early on, but it is a lot >> harder to read and understand. >> >> Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx> >> --- >> net/bluetooth/hci_core.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) > > Both patches in this set have been applied to bluetooth-next. Thanks. so my cleanup patch was actually a mistake. In itself it was the right fix, but with the follow up patch, we actually want it that way to allow the invalid_bdaddr variable assignment to be done after hdev->setup. I posted a v2 now that fixes that. We need to do a push --force to fix this up. A follow up patch would cause a hard to track history. Regards Marcel
