Re: [PATCH 0/6] Add features and fix some undesired behaviour of meshctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniele,

On Mon, 2019-11-18 at 14:43 +0100, Daniele Biagetti wrote:
> From: Daniele <
> dbiagio@xxxxxxxxxx
> >
> 
> The followings extend the features of meshctl, adding:
>  * The Subscription Delete message to the configuration client 
>    (as per Mesh Profile 4.3.2.21)
>  * The Generic OnOff Set Unacknowledged message to the onoff
>    client model
>  * Generic Level Client Model, limited to the following messages:
>    - generic level get and set
>    - generic level set unacknowledged
>    - generic level status
>  * Generic Power OnOff Client except the Generic OnPowerUp Set
>    Unacknowledged message
> They also contains two fixes:
>  * The first one cames up when more than a client model is added
>    to the local node. The received status messages are forwarded
>    to all clients and they needs to be filtered within each client
>    in order to avoid wrong reports on the bt shell
>  * The second one replaces a return statment within the onoff 
>    client model with a warning message when the user selects an
>    unknown target address. For example it happens when the user 
>    tries to send messages to a group address due to the fact that
>    such addresses are not stored whitn the json database.
> 
> Daniele (6):
>   tools/mesh: Add onoff set unack message to onoff client model
>   tools/mesh: Fix status messages processing
>   tools/mesh: Fix unwanted return in onoff client model
>   tools/mesh: Add subscription delete message to config client model
>   tools/mesh: Add generic level model support
>   tools/mesh: Add generic power onoff client model
> 
>  Makefile.tools               |   4 +-
>  tools/mesh/config-client.c   |  40 +++++
>  tools/mesh/level-model.c     | 298
> +++++++++++++++++++++++++++++++++++
>  tools/mesh/level-model.h     |  34 ++++
>  tools/mesh/local_node.json   |  10 +-
>  tools/mesh/node.c            |  11 ++
>  tools/mesh/onoff-model.c     |  52 ++++--
>  tools/mesh/onpowerup-model.c | 262 ++++++++++++++++++++++++++++++
>  tools/mesh/onpowerup-model.h |  34 ++++
>  tools/meshctl.c              |   8 +
>  10 files changed, 734 insertions(+), 19 deletions(-)
>  create mode 100644 tools/mesh/level-model.c
>  create mode 100644 tools/mesh/level-model.h
>  create mode 100644 tools/mesh/onpowerup-model.c
>  create mode 100644 tools/mesh/onpowerup-model.h
> 
> 

It looks like the patches are not generated against the tip of the
BlueZ tree. The meshctl specific files are now residing in tools/mesh-
gatt directory. You would need to update the BlueZ source and
regenerate the patches.

Best regards,
Inga  




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux