Hi,
On Thu, Nov 14, 2019 at 11:20 AM Abhishek Pandit-Subedi
<abhishekpandit@xxxxxxxxxxxx> wrote:
>
> > > Example:
> > > @@ -40,5 +45,11 @@ Example:
> > > bluetooth {
> > > compatible = "brcm,bcm43438-bt";
> > > max-speed = <921600>;
> > > +
> > > + brcm,bt-sco-routing = [01];
> > > + brcm,pcm-interface-rate = [02];
> > > + brcm,pcm-frame-type = [00];
> > > + brcm,pcm-sync-mode = [01];
> > > + brcm,pcm-clock-mode = [01];
> >
> > I'm at least marginally curious why your example has a leading 0 for
> > all numbers. It makes me think you intend them to be represented in
> > octal, though I don't know offhand if dtc uses that format for octal.
> > I guess it doesn't matter since all your numbers are between 0 and 5,
> > but it does seem strange.
>
> It's a bytestring with a length of 1. See bytestrings under
> https://devicetree-specification.readthedocs.io/en/latest/source-language.html#node-and-property-definitions
Oh, right! ...except that now it's just one value and not an array of
values, just make it a normal number. Don't worry about the fact that
it'll take up 4 bytes instead of 1--it's clearer for it to just be a
normal number.
...I would also note that the definition of the properties talks
nothing about them being a bytestring. ;-)
-Doug
