Re: [PATCH BlueZ] unit: Fixed Mesh Crypto unit test build for LTO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Applied

On Tue, 2019-11-05 at 14:58 -0800, Brian Gix wrote:
> Was erroneously compiling and linking explicit unit test versions of the
> ELL source dependancies while also linking with the library made from
> same sources. This created Link Time Optimization (LTO) problems when
> calling exit(), as there were two copies of the constructors and
> destructors from ell/log.c.
> ---
>  Makefile.am | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 84c9712c9..8d419fb30 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -524,10 +524,8 @@ if MESH
>  unit_tests += unit/test-mesh-crypto
>  unit_test_mesh_crypto_CPPFLAGS = $(ell_cflags)
>  unit_test_mesh_crypto_SOURCES = unit/test-mesh-crypto.c \
> -				mesh/crypto.h ell/internal ell/ell.h \
> -				$(ell_sources)
> -unit_test_mesh_crypto_LDADD = src/libshared-ell.la \
> -			$(ell_ldadd)
> +				mesh/crypto.h ell/internal ell/ell.h
> +unit_test_mesh_crypto_LDADD = $(ell_ldadd)
>  endif
>  
>  if MAINTAINER_MODE




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux