Hi Jaganath, On Mon, Oct 28, 2019 at 6:50 PM Jaganath K <jaganath.k.os@xxxxxxxxx> wrote: > > Hi Marcel, > > On Sat, Oct 26, 2019 at 11:02 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > > > > Hi Jaganath, > > > > >>> By default for instance 0, local name will be added for scan rsp > > >>> data, but currently the property is set as non scannable and hence > > >>> Set Adv parameter fails with Invalid parameter. > > >> > > >> can you be a bit more specific why this is the correct behavior. We must have documented in mgmt-api.txt somewhere, right? Or is this something that used to be correct, but we broke it with adding extended advertising? > > > > > > It seems to be functionally broken in legacy adv as well as we set scan rsp > > > for instance 0 always but Adv Properties is set to non connectable (if > > > connectable > > > is not set). Even we need to fix mgmt-api.txt as well as you pointed out. > > > > > > But in legacy case commands do not fail as scan rsp can be set even before > > > Set Adv Param where as in extended case Adv param for an Adv set has to be set > > > first before sending Scan rsp and other commands for that particular Adv set. > > > > how does this intersect with the patches that Luiz was sending earlier? > > > I think Luiz patches covers both the issues. Yep, my patches were actually targeting the same issues, though you had a better description, anyway it is a fix nevertheless. -- Luiz Augusto von Dentz
