Hi Amit,
> Sometimes during FW data download stage, in case of an error is
> encountered the controller device could not be recovered. To recover
> from such failures send Intel hard Reset to re-trigger FW download in
> following error scenarios:
>
> 1. Intel Read version command error
> 2. Firmware download timeout
> 3. Failure in Intel Soft Reset for switching to operational FW
> 4. Boot timeout for switching to operaional FW
>
> Signed-off-by: Raghuram Hegde <raghuram.hegde@xxxxxxxxx>
> Signed-off-by: Chethan T N <chethan.tumkur.narayan@xxxxxxxxx>
> Signed-off-by: Amit K Bag <amit.k.bag@xxxxxxxxx>
> ---
> drivers/bluetooth/btintel.c | 46 +++++++++++++++++++++++++++++++++++++++++++++
> drivers/bluetooth/btintel.h | 6 ++++++
> drivers/bluetooth/btusb.c | 20 ++++++++++++++++----
> 3 files changed, 68 insertions(+), 4 deletions(-)
So this patch has a bunch of errors
Applying: Bluetooth: btusb: Trigger Intel FW download error recovery
.git/rebase-apply/patch:97: trailing whitespace.
btintel_reset_to_bootloader(hdev);
warning: 1 line adds whitespace errors.
CC drivers/bluetooth/btintel.o
drivers/bluetooth/btintel.c: In function ‘btintel_reset_to_bootloader’:
drivers/bluetooth/btintel.c:733:20: error: assignment of member ‘reset_type’ in read-only object
733 | params.reset_type = 0x01;
| ^
drivers/bluetooth/btintel.c:734:22: error: assignment of member ‘patch_enable’ in read-only object
734 | params.patch_enable = 0x01;
| ^
drivers/bluetooth/btintel.c:735:20: error: assignment of member ‘ddc_reload’ in read-only object
735 | params.ddc_reload = 0x01;
| ^
drivers/bluetooth/btintel.c:736:21: error: assignment of member ‘boot_option’ in read-only object
736 | params.boot_option = 0x00;
| ^
drivers/bluetooth/btintel.c:737:20: error: assignment of member ‘boot_param’ in read-only object
737 | params.boot_param = cpu_to_le32(0x00000000);
| ^
drivers/bluetooth/btintel.c:716:6: warning: unused variable ‘boot_param’ [-Wunused-variable]
716 | u32 boot_param;
| ^~~~~~~~~~
I would really encourage to test the patch with git am and compile test it at least since these are obvious bugs.
Anyway, I manually fixed this up and applied to patch to bluetooth-next tree.
Regards
Marcel
