Re: [PATCH BlueZ v2 2/5] mesh: Validate application by comparing composition data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Inga,

On 07/24, Stotland, Inga wrote:
> > -		ele->path = l_strdup(path);
> 
> The path needs to be preserved if this is the Attach() request.
> One way to do this would be to save it here, in the temporary node and
> then after all the checks are done, move it to the node that is "owned"
> by the daemon prior to deleting the temporary node in
> get_managed_objects_cb()
(...)
> 
> So here, prior to removing the temorary node, the element paths need to
> be copied into the "req->attach" version of the node.
> Same goes for node->agent and node->provisioner.	

True, thanks! I'll fix this in v3.

> "Location" property is described as optional in mesh-api.txt. It's
> populated with "Default Location", if the property is not present.
> I believe, it was more out of the convenience for the app develpers,
> but maybe we should change the property description as mandatory, i.e.,
> remove "optional" from the property descrition in mesh-api.txt

I'm inclined to make this property mandatory, but I don't have a strong
opinion about it. So just tell me how should it be and I'll adjust v3
accordingly.

-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@xxxxxxxxxxx>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux